This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow sizes attribute in headLink (used with rel="icon")
#6635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marek-saji |
| @@ -35,7 +35,7 @@ class HeadLink extends Placeholder\Container\AbstractStandalone | |||
| * | |||
| * @var array | |||
| */ | |||
| protected $itemKeys = array('charset', 'href', 'hreflang', 'id', 'media', 'rel', 'rev', 'type', 'title', 'extras'); | |||
| protected $itemKeys = array('charset', 'href', 'hreflang', 'id', 'media', 'rel', 'rev', 'sizes', 'type', 'title', 'extras'); | |||
There was a problem hiding this comment.
Can we convert this to a one-per-line syntax? The diffs are hard to read as-is.
|
Also: needs a rebase |
Ocramius
added a commit
that referenced
this pull request
Dec 5, 2014
Ocramius
added a commit
that referenced
this pull request
Dec 5, 2014
|
@marek-saji manually added tests and merged, thanks! |
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…s declaration to one-per-line for readability
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…n the 'sizes' attribute
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…s-for-rel-tag' into develop Close zendframework/zendframework#6635 Forward port zendframework/zendframework#6635
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://www.w3.org/TR/html5/links.html#attr-link-sizes