This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
added missing register services at Zend\Paginator\AdapterPluginManager #6577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| return new DbTableGateway( | ||
| $this->creationOptions[0], | ||
| isset($this->creationOptions[1]) ? : null, |
There was a problem hiding this comment.
This does not inject the value of $this->createOptions[1]. If you leave out the middle part of the ternary operator, the value of the first expression is returned which is the result of isset($this->createOptions[1]) (true of false).
There was a problem hiding this comment.
Good catch. Indeed, @samsonasik: the elvis operator does not work well with isset()
There was a problem hiding this comment.
thanks, fixed now.
|
Also: requires tests for the newly introduced factory |
|
@Ocramius I think "awaiting author updates" label can be uncheck now :D |
|
@samsonasik thanks: poke me if I don't review within the end of next week :) |
|
ping @Ocramius any review for it ? Thanks |
samsonasik
force-pushed
the
add-missing-register-service
branch
from
a05ab85
to
0669b67
Compare
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
|
@samsonasik merged, thanks! |
gianarb
pushed a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
…paginator-adapter-plugin-manager-registered-services' Close zendframework/zendframework#6577
gianarb
pushed a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
…paginator-adapter-plugin-manager-registered-services' into develop Close zendframework/zendframework#6577 Forward port zendframework/zendframework#6577
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.