replacing array_key_exists with faster isset calls

[pine3ree]

should we also change has checkers with isset() || array_key_exists() ?

[Ocramius]

@pine3ree yes, it should be using || array_key_exists()

[Ocramius]

Actually, never mind: if isset() fails, then null is returned, so || array_key_exists() is not required.

[pine3ree]

When using getter it's always preferable using isset alone, since it covers all the cases.
With hassers I tend to use both (isset 1st): an array may "have" an element for a particular key and that element can be NULL.

[Ocramius]

Yeah, the patch is good as-is. The trailing spaces are still caught by the CS checks in the test suite though...

[pine3ree]

oh, yeah...sorry. it always happend to me when editing directly on github (due to my obsession of having a blank line b4 return). There's still a couple of assert equal errors in tests/ZendTest/Feed/Reader/Entry/AtomTest.php:148
tests/ZendTest/Ldap/Converter/ConverterTest.php:104
in 5.4 - 5.5 - 5.6
will look into it.

[pine3ree]

mmm shouldn't be related to form elements at all.

[Ocramius]

@pine3ree yeah, build is ok for what is related to this PR now. No further action needed

[weierophinney]

Actually... empty strings are valid labels in this case, and should not return null. Since isset('') returns false, array_key_exists() is the more appropriate call here.

[pine3ree]

@weierophinney

??

empty strings array values returns TRUE

$arr = array(
    'key' => '',
);

var_dump(isset($arr['key']));

echoes bool(true)

[Ocramius]

@weierophinney you probably misread this one :-) Re-opening

[pine3ree]

@weierophinney

Honestly, i still don't understand what you mean or where isset('') does apply.

I just changed the getters for labelOptions and attributes arrays with a very common optimization and I am applying isset to arrays not to strings that can be empty.

since i have only used isset like this:

isset($arr[$key]);

applying your use case that would mean $arr[$key] could be '', which returns TRUE if checked with isset.

Can you give me any example of the case you had in mind? What am I missing?

kindly.

[Ocramius]

@pine3ree it was just a PEBKAC, not intentional :-)

[pine3ree]

don't we all suffer from it? :-)
...meaning that I was so concentrated on another project that I read your reply to weierophinney as a weierophinney reply to me, and i replied back....

[Ocramius]

This was merged manually, thanks @pine3ree!

master: b6926ef
develop: c4709ca