This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fix #6480 #6484
Closed
fix #6480 #6484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mattmakins, can you also provide a test case that shows what is being fixed here and prevents regressions? Also linking #6480 |
| @@ -35,10 +37,15 @@ public static function fromString($headerLine) | |||
| } | |||
|
|
|||
| // @todo implementation details | |||
| $header->value = $value; | |||
| $header = new static($value); | |||
There was a problem hiding this comment.
return directly instead of assigning to $header
update OriginTest to test getFieldValue fix
| @@ -9,3 +9,5 @@ build/ | |||
| composer.lock | |||
| nbproject | |||
| tmp/ | |||
|
|
|||
| composer.phar | |||
There was a problem hiding this comment.
revert this, no relation change should on separate PR
added 2 commits
August 4, 2014 19:50
Ocramius
added a commit
that referenced
this pull request
Aug 6, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 6, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 6, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 6, 2014
Ocramius
added a commit
that referenced
this pull request
Aug 6, 2014
|
@mattmakins I cleaned up somethings, rebased and merged. Thank you! Keep going :-) |
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…ould always be a string
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…s be a string
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…n-header-instantiation' Close zendframework/zendframework#6484
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…n-header-instantiation' into develop Forward port zendframework/zendframework#6484
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution so I hope I have followed the guidelines correctly.