This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Add body to curl DELETE request if one is specified. #6318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
added a commit
that referenced
this pull request
Jul 27, 2014
… into develop Forward port #6318
|
@lucian303 merged, thanks |
This was referenced Jul 27, 2014
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…rk/zf2#6315-add-body-to-curl-delete-request' Close zendframework/zendframework#6318 Close zendframework/zendframework#6315
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…rk/zf2#6315-add-body-to-curl-delete-request' into develop Forward port zendframework/zendframework#6318
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header will be there. Fixes issue #6315 (#6315).
When providing a request body for a DELETE request, Zend\Http\Client will add the 'Content-Length' header but will not add and send the actual body resulting in a curl call that hangs for a very long period of time. The client should send both a body and the header since DELETE requests can have a body. From the IETF spec: "The presence of a message-body in a request is signaled by the inclusion of a Content-Length or Transfer-Encoding header field in the request's message-headers." -- http://tools.ietf.org/html/rfc2616