This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixes issue #4747 - FileGenerator now properly generates files. #6302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears there is another random unit test failure not associated to the code change. |
|
I just want to note also that the setBody and getBody methods are kind of confusing for this class. In reality it is used to append to the content of the file. |
|
Linking #4747 |
Ocramius
added a commit
that referenced
this pull request
Jul 28, 2014
…s-files' into develop Forward port #6302
|
Merged, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class appears to be very fragile and fragmented in terms of how it works. My guess is that there are edge cases that aren't covered in the unit tests.
I have added 2 new tokens for namespace and uses as well as a duplicate check on uses. In addition the fromReflection method no longer attempts to build the body as this is done via the generate method.