This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Added new base path option specifically for console #6247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tldev needs a test case to demonstrate what feature is being introduced here... |
|
@Ocramius will this suffice? |
Ocramius
added a commit
that referenced
this pull request
Nov 14, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 14, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 14, 2014
…sole' into develop Close #6247
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently implementing something similar in my application, and thought maybe you guys would like the idea.
Basically, for normal http requests, I want to always fallback to using the request object, for both development and production, but for console, I want to explicitly set the base_path. I need the basePath view helper on a console request so I can send emails via cronjob with the correct urls to my application. If I set the base_path with how the factory currently works, I have to now worry about setting the correct base_path no matter what the application environment is even though the request object works perfectly fine.