This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix: Exceptions raised in Soap/Server can leave XML entity loader disabled. #6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disabled. - The original libxml_disable_entity_loader() setting was not restored when an exception was raised in Server::_setRequest(). - Fixed by moving the libxml_disable_entity_loader(false) call a bit further up. - Added unittest for the intended behaviour.
…abled. - Improved the fix a bit: Instead of forcing entity loading to "false", the previous setting is saved and restored. - Adjusted the unittest accordingly.
Ocramius
added a commit
that referenced
this pull request
Apr 29, 2014
|
@markkirchner thanks! |
gianarb
pushed a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
…entity-loader-in-soap-server' Close zendframework/zendframework#6200
gianarb
pushed a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
…entity-loader-in-soap-server' into develop Close zendframework/zendframework#6200 Forward Pory zendframework/zendframework#6200
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libxml_disable_entity_loader()setting was not restored when an exception was raised in\Zend\Soap\Server::_setRequest().libxml_disable_entity_loader()"cleanup call" a bit further up.