Timestamp log filter

[nikolaposa]

Log filter which provides ability to filter log events based on the time when they were triggered.

It can be configured by specifying idate()-compliant format character and desired value or a DateTime instance for direct comparison with the log event's timestamp. Comparison operator must also be supplied in either cases.

Example usage:

use Zend\Log\Logger;
use Zend\Log\Writer\Stream as StreamWriter;
use Zend\Log\Filter\Timestamp as TimestampFilter;

$logger = new Logger();

$writer = new StreamWriter('/path/to/first/logfile');
//Log only events between 10 and 13 hours
$writer->addFilter(new TimestampFilter(10, 'H', '>='));
$writer->addFilter(new TimestampFilter(12, 'H', '<='));
$logger->addWriter($writer);

[samsonasik]

no need else, just return directly because already return early in previous if

[nikolaposa]

I do understand your point, but I prefer to use explicit else in these kind of situations, in order to "highlight" that two different strategies/directions. On the other hand, in case of raw boolean return statements, I use that "no else" approach, with that last, fallback return statement at the very end of a method declaration.

But if you insist, I'll alter this...

[samsonasik]

I already did a lot of work at the pass for removing else because already return early, see #3286

[Ocramius]

Shouldn't the operator be validated?

[nikolaposa]

I frankly haven't seen any validation on $operator in Zend\Log\Filter\Priority, which is also based on the version_compare() function. Do you think that I should at least add some type check (is string)?

[Ocramius]

@nikolaposa what are the allowed operator here? The PHP docs mention The possible operators are: <, lt, <=, le, >, gt, >=, ge, ==, =, eq, !=, <>, ne respectively..

The fact that the priority filter doesn't have strict checks doesn't mean that we can't apply them here.

[nikolaposa]

Ok, no problem, I'll put some validation there.

[weierophinney]

Please do not use extract; test for values in the array instead, and set the locally declared variables based on what you find in the array.

[nikolaposa]

Why is this build failing? I suppose that the problem is in some other commit, because test failure points to "ZendTest\Cache\Storage\Adapter\FilesystemTest::testClearExpired". What should be done in such situations, in order to make my commit "green"? Should I rebase with master and then force push?

[Ocramius]

@nikolaposa it's a race condition that happens quite often in the builds, sadly :(

[nikolaposa]

Do I need to take any action on this issue?

btw Can this situation be prevented somehow? Maybe with more frequent master rebasing?

[Ocramius]

@nikolaposa the bug has not yet been solved, so rebasing won't help anyway. No action required for that failure

[Ocramius]

@nikolaposa one thing that is needed here is documentation for the new feature - think you can prepare a PR for that? I've scheduled merging for this once that's done.

[nikolaposa]

Should I create/submit that pull request to the ZF2 docs project (https://github.com/zendframework/zf2-documentation) or in some other way?

[Ocramius]

@nikolaposa that is the correct way :-)