This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fixed charset support for Pdo_Pgsql. #6033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, charset is not a portable key in the dsn. I'll get this merged in in the next week, I also looked through the docs and noticed there are a few other places where charset might need to be omited for a given driver. |
weierophinney
added a commit
that referenced
this pull request
May 12, 2014
Fixed charset support for Pdo_Pgsql.
weierophinney
added a commit
that referenced
this pull request
May 12, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Release 2.3, the "charset" option is passed to PDO. This is not supported for all PDO drivers. In particular, The pgsql driver throws an exception if the DSN contains the "charset" option.
I created a workaround for Pdo_Pgsql. Please note that the quoting of $charset is not 100% secure if the charset is not already set. Either set the encoding to a default charset before setting the final charset, validate the string to be plain ASCII, or document that the value cannot be trusted in regards to possible SQL injection.
For uniform charset handling, other drivers (PDO and non-PDO) may need special treatment as well.