Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fix BC break in TranslatorServiceFactory #5979

Closed
wants to merge 1 commit into from
Closed

Fix BC break in TranslatorServiceFactory #5979

wants to merge 1 commit into from

Conversation

Martin-P
Copy link
Contributor

Fix for issue #5978. The check for the intl extension must be done after checking for the translator config key, not before. The test for this was deactivated, this PR also reactivates that test again.

@roelvanduijnhoven
Copy link
Contributor

This would also solve issues that I am having. In my configuration the ocale is explicitly set, thus no need to fall back to DummyTranslator.

@Martin-P
Copy link
Contributor Author

Martin-P commented Apr 1, 2014

Did a rebase on my branch, because the CS-fixer was broken and made Travis fail. All is well now :)

@Ocramius Ocramius added this to the 2.3.1 milestone Apr 3, 2014
@Ocramius Ocramius self-assigned this Apr 3, 2014
Ocramius added a commit that referenced this pull request Apr 3, 2014
@Ocramius
Merge branch 'hotfix/#5979-#5978-translator-service-factory-without-i…
bf42e30 
…ntl' into develop

Close #5979 #5978
Forward Port #5979 #5978
@Ocramius Ocramius closed this in 2ac901c Apr 3, 2014
@samsonasik samsonasik mentioned this pull request Apr 5, 2014
Closed
@Martin-P Martin-P deleted the issue-5978 branch August 13, 2014 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
bug I18n Mvc
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Martin-P @roelvanduijnhoven @Ocramius