Fix for issue #4267

[god107]

No description provided.

[samsonasik]

add new line after function name, see PSR-2 https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#43-methods

[god107]

Ok, I thought that cs fixer is doing that in pre-commit hook.

I don't know why Tests are failed.

[god107]

Ok, now it should be correct. Test on my pc passed after first commits but i'm using newer version of PHP. Don't even know before that empty() accepts only variables nor returned values by function prior to PHP 5.5.

[ThaDafinser]

@god107 looking sadly at travis there was a timeout...
Maye enhance the test even further and test for is_string()
And display the message: "Only non empty strings are allowed as input"

[god107]

ok, i'll fix this but i have question: What about that Travis show timeout for connecting to github:

The command "git clone --depth=50 git://github.com/zendframework/zf2.git zendframework/zf2" failed. Retrying, 3 of 3.
Cloning into 'zendframework/zf2'...
fatal: unable to connect to github.com:
github.com: Temporary failure in name resolution
The command "git clone --depth=50 git://github.com/zendframework/zf2.git zendframework/zf2" failed and exited with 128 during checkout.

[samsonasik]

it's travis issue I think ;). I think you should no worry about that :D. It
usually fixed with next commit / squash the commit :D

Warm Regards,

Abdul Malik Ikhsan

2014-03-10 16:12 GMT+07:00 Marcin Twardowski notifications@github.com:

ok, i'll fix this but i have question: What about that Travis show timeout
for connecting to github:

The command "git clone --depth=50 git://github.com/zendframework/zf2.git zendframework/zf2" failed. Retrying, 3 of 3.
Cloning into 'zendframework/zf2'...
fatal: unable to connect to github.com:github.com: Temporary failure in name resolution
The command "git clone --depth=50 git://github.com/zendframework/zf2.git zendframework/zf2" failed and exited with 128 during checkout.

Reply to this email directly or view it on GitHubhttps://github.com//pull/5936#issuecomment-37163747
.

[god107]

Strange, now i'm seeing that test in ZendTest/Cache failed but i did'n touch there anything. :/

[samsonasik]

Don't worry about that ;)

Warm regards,

Abdul Malik Ikhsan

Pada 10 Mar 2014, pukul 16.54, Marcin Twardowski notifications@github.com menulis:

Strange, now i'm seeing that test in ZendTest/Cache failed but i did'n touch there anything. :/

—
Reply to this email directly or view it on GitHub.

[weierophinney]

Merged to develop for release with 2.3.0.