This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow merging text domains without plural rules #5908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ($this->pluralRule === null) { | ||
| $this->setPluralRule(PluralRule::fromString('nplurals=2; plural=n != 1;')); | ||
| if (self::$defaultPluralRule === null) { | ||
| self::$defaultPluralRule = PluralRule::fromString('nplurals=2; plural=n != 1;'); |
There was a problem hiding this comment.
should it be static:: instead of self:: ?
weierophinney
added a commit
that referenced
this pull request
Mar 5, 2014
…al-merging Allow merging text domains without plural rules
weierophinney
added a commit
that referenced
this pull request
Mar 5, 2014
- in order to invoke LSB for extensions
weierophinney
added a commit
that referenced
this pull request
Mar 5, 2014
|
Merged to develop for release in 2.3.0. |
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
…ix/text-domain-without-plural-merging Allow merging text domains without plural rules
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
- in order to invoke LSB for extensions
weierophinney
added a commit
to zendframework/zend-i18n
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue addressed by #5277 in a much cleaner way. Thus closes #5277.