This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Update NotEmptyTest tests to use data providers where possible #5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dstockto thanks! Awesome! |
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…-data-provider-refactoring' Close zendframework/zendframework#5879
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…-data-provider-refactoring' into develop Close zendframework/zendframework#5879 Forward port zendframework/zendframework#5879
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than making a dozen or so assertions in a test, converting to @dataProvider tests means we will know each value that fails for each test.
I refactored the tests for the NotEmpty validator to use dataproviders which means it should now show 245 tests with 253 assertions compared to 28 tests with 248 assertions previously.
Additionally, I removed the two test classes that were defined at the end of this file and replaced them with PHPUnit mock objects in the tests where they were being used.