This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Soap\Client\DotNet][FIX] Undefined property in void return #5793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -216,7 +216,10 @@ protected function _preProcessArguments($arguments) | |||
| protected function _preProcessResult($result) | |||
| { | |||
| $resultProperty = $this->getLastMethod() . 'Result'; | |||
| return $result->$resultProperty; | |||
| if(isset($result->$resultProperty)){ | |||
There was a problem hiding this comment.
add space before and after parenthesis , see PSR-2 https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#51-if-elseif-else
|
Yes, of course. |
|
travis build failure |
|
Fixed, typo error... And the current Travis build, fail because of github :
|
|
Change, |
weierophinney
added a commit
that referenced
this pull request
Mar 4, 2014
[Soap\Client\DotNet][FIX] Undefined property in void return
weierophinney
added a commit
that referenced
this pull request
Mar 4, 2014
weierophinney
added a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
…pDotNetEmptyResult [Soap\Client\DotNet][FIX] Undefined property in void return
weierophinney
added a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dotNet soap implementation send the result in a [LastRequest]Result xml node, so the DotNet _preProcessResult return directly this node.
But in some case, when the method return nothing and if this behaviour is not defined in the ws defition (wsdl for example), a notice error is raised because the searched node does not exists.
So I have added an exists condition on the [LastRequest]Result xml node to avoid this error.
The code is not unit-tested because I don't know how to test this peculiar behaviour, but the modification is really really tiny.