This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Addressing issue #5624. Implemented fix and added test case. #5644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfigures Smd; Updated toArray on Zend/Json/Server/Smd and Smd/Service to include the required attributes according to the SMD spec
| } | ||
|
|
||
| return $paramInfo = compact('envelope', 'target', 'transport', 'parameters', 'returns'); | ||
| return $paramInfo = compact('envelope', 'target', 'transport', 'name', 'parameters', 'returns'); |
There was a problem hiding this comment.
You might as well remove $paramInfo = ?
There was a problem hiding this comment.
I'm willing to--generally I like to make my changes as minimal as possible so I only changed what needed to be changed.
weierophinney
added a commit
that referenced
this pull request
Mar 3, 2014
Addressing issue #5624. Implemented fix and added test case.
weierophinney
added a commit
to zendframework/zend-json
that referenced
this pull request
May 15, 2015
…on/ZF2-5624 Addressing issue zendframework/zendframework#5624. Implemented fix and added test case.
weierophinney
added a commit
to zendframework/zend-json
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-json
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated toArray on Zend/Json/Server/Smd and Smd/Service to include the required attributes according to the SMD spec; Added test to show setOptions on toArray output appropriately configures Smd