Php unit windows #5369
Php unit windows #5369
Conversation
This reverts commit 47f5a6a.
|
@ThaDafinser I use bat file for Windows context menu: |
|
@turrsis is the failing because of the formatting? Oo |
|
Ahhh better =) |
|
@turrsis thanks for the hint... There are still unresolved issues for testing under windows, but many are fixed with this PR |
| @@ -72,7 +72,9 @@ public function testSaveXmlOutputsXmlStringForEntry() | |||
| file_get_contents($this->feedSamplePath.'/atom.xml') | |||
| ); | |||
| $entry = $feed->current(); | |||
| $this->assertEquals($entry->saveXml(), file_get_contents($this->feedSamplePath.'/atom_rewrittenbydom.xml')); | |||
| $expected = file_get_contents($this->feedSamplePath.'/atom_rewrittenbydom.xml'); | |||
There was a problem hiding this comment.
PHP handles paths converting itself. The DIRECTORY_SEPERATOR is only needed when it comes to comparison.
|
Nothing of this is not resolve the problems. @ThaDafinser To my mind - you should check CrLf settings for your git. |
|
@ThaDafinser Comments on @Maks3w still actual. |
|
@turrsis i'm really sorry, but i have a lot of problems understanding your sentences. What is with the comments from @Maks3w ? Do you have problems with '/' for file loading in your ENV? It should be only a problem when it comes to comparison The EOL in my ENV is \r\n (but that should be fixed by the php-cs-fixer or not?) |
|
@ThaDafinser try to revert you changes, change CrLf settings for your git, clone zf2 again to new folder, run tests - |
ghost
assigned
|
Sorry - my previous comment is realy hard for undertanding.
|
…phpUnitWindows Php unit windows
…phpUnitWindows Php unit windows
…phpUnitWindows Php unit windows
…phpUnitWindows Php unit windows
…phpUnitWindows Php unit windows
…phpUnitWindows Php unit windows
Under windows there are currently a lot of failing tests.
Most problem is \n instead of \r\n.
Some of the problems are fixed with this PR.