This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
using injected response object #5068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a unit test for this. |
|
oh - my bad :) |
weierophinney
added a commit
that referenced
this pull request
Sep 4, 2013
using injected response object
ghost
assigned
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
using injected response object
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario:
Invalid HTTP codes are coming in from a webservice (in our case 497).
An exception is being thrown in HttpClient, if a constant with name STATUS_CODE_ is not existing in response entity. When setting a response object in the HTTP client containing the "missing" constant, i expected exactly this response object coming back from $client->send().
In The client the following happens:
A new response object of type Zend\Http\Response is created on incoming response, instead of the injected one, which can be retrieved using $this->getResponse().
Current (dirty) Solution is to catch the exception and call the fromString method in the CustomResponse class containing the additional STATUS_CODE_'s.