This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Zend-Code] Find php 5.4 traits with TokenArrayScanner #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a unit test for this as well -- and thanks! |
Added T_TRAIT next to T_CLASS and T_INTERFACE. For php 5.3 T_TRAIT gets defined to not get any errors.
|
Added test before fixing issue |
|
composer on travis not working -> failed |
|
@danez Try waiting a few hours and then closing an re-opening the PR. |
|
Ok i'll try that |
|
Thanks for the tip. |
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Aug 21, 2013
[Zend-Code] Find php 5.4 traits with TokenArrayScanner
weierophinney
added a commit
that referenced
this pull request
Aug 21, 2013
|
Merged to develop for release with 2.3.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added T_TRAIT next to T_CLASS and T_INTERFACE.
For php 5.3 T_TRAIT gets defined to not get any errors.