Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

make use of mickey179/vfsStream in unit tests: Zend\Test #4913

Closed
wants to merge 1 commit into from

Conversation

prolic
Copy link
Contributor

@prolic prolic commented Jul 30, 2013

No description provided.

@Ocramius
Copy link
Member

Uhhh... what is this for exactly @prolic?

@prolic
Copy link
Contributor Author

prolic commented Jul 30, 2013

vfsStream is a stream wrapper for a virtual file system that may be helpful in unit tests to mock the real file system

@Ocramius
Copy link
Member

@prolic yes, but I wouldn't mock the actual file system... we're always having trouble with it, and it's a good thing because that's actually telling us when we do it wrong...

@prolic
Copy link
Contributor Author

prolic commented Jul 30, 2013

problem is, that you can't run tests in parallel.

i never recognized any problems with vfsStream, but if that's the only problem, how about using something linke uniqid(microtime(true)) ? that way we don't use vfsStream (again, I don't know what the problem is, when using this library), but we can run the test suite in parallel.

Footnote: I am trying to get the zf2 test suite running with https://github.com/brianium/paratest, most components just run immediatly in a much shorter time.

@ghost ghost assigned weierophinney Aug 19, 2013
@weierophinney
Copy link
Member

I've actually been thinking about doing this for a while. There are more places in the framework where it would be useful, but this is a good start.

I'm going to merge to the develop branch, however, as it's a new requirement (albeit only for dev).

weierophinney added a commit that referenced this pull request Aug 19, 2013
make use of mickey179/vfsStream in unit tests: Zend\Test
weierophinney added a commit that referenced this pull request Aug 19, 2013
@prolic
Copy link
Contributor Author

prolic commented Aug 19, 2013

I can go on with this topic, after I got my other project on a beta release. :-)

Can the ticket now be closed, as you merged, and didn't close?

@prolic prolic deleted the Testfixes branch August 20, 2013 13:42
weierophinney added a commit to zendframework/zend-test that referenced this pull request May 15, 2015
…ixes

make use of mickey179/vfsStream in unit tests: Zend\Test
weierophinney added a commit to zendframework/zend-test that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants