This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Composer dependencies fixed #4584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "suggest": { | ||
| "zendframework/zend-config": "Zend\\Config component", |
There was a problem hiding this comment.
Zend\Mvc should require Zend\Config. See #3908
There was a problem hiding this comment.
@danizord As far as I understand from #3908, Zend\Mvc requires Zend\ModuleManager and Zend\ModuleManager in turn requires Zend\Config. But Zend\Mvc should not require Zend\Config. Zend\Mvc gets Zend\Config through dependency if it use Zend\ModuleManager.
@weierophinney What do you think about this?
There was a problem hiding this comment.
@ossinkine The Zend\Config is optional for Zend\ModuleManager, but required for Zend\Mvc.
There was a problem hiding this comment.
@danizord Zend\Config is used in Zend\ModuleManager\Listener\DefaultListenerAggregate. DefaultListenerAggregate is used in Zend\Mvc\Service\ModuleManagerFactory, but you can use other factory for ModuleManager in Zend\Mvc\Application. Therefore, packages in "require-dev" and "suggest" sections. Zend\Config in Zend\ModuleManager, Zend\ModuleManager in Zend\Mvc. Moreover, Zend\Mvc requires not only for Zend\Mvc\Application.
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Jun 28, 2013
Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
|
Merged to develop for release with 2.3.0 -- Thanks, @ossinkine ! |
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-mail
that referenced
this pull request
May 14, 2015
weierophinney
added a commit
to zendframework/zend-barcode
that referenced
this pull request
May 14, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-barcode
that referenced
this pull request
May 14, 2015
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-servicemanager
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-math
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-math
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-loader
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-loader
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-memory
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-memory
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-inputfilter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-progressbar
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-progressbar
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-filter
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…mposer-dependencies Composer dependencies fixed Conflicts: library/Zend/Captcha/composer.json library/Zend/ProgressBar/composer.json library/Zend/Validator/composer.json
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added needed packages to "require", "require-dev" and "suggest" sections in composer.json.
See #4519