This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Need way to specify in the logger configuration the factory for the own writer #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right; it's not possible yet. The logger service factories we have currently always instantiate a logger instance directly, and do not inject the writer or processor plugins, which means you can only use defaults currently. Scheduling for 2.3.0, as we will need to add the writer and processor plugin managers to the service manager first, and then alter the existing factories to use them. As such, we will have new functionality, which is reserved for new minor versions. |
|
I understood, thanks for the clarification |
|
Is this still something we need to keep open? |
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
Mar 5, 2014
- Allows passing the WriterPluginManager to the Logger constructor. - Adaptes the LoggerAbstractServiceFactory to inject the WriterPluginManager into the configuration prior to instantiating the logger.
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
Mar 5, 2014
- Allows passing the ProcessorPluginManager to the Logger constructor - Adaptes the LoggerAbstractServiceFactory to inject the ProcessorPluginManager into the configuration prior to instantiating the logger.
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
Mar 5, 2014
- LogWriterManager and LogProcessorManager services. - Wired into base service manager configuration, as well as ModuleManager feature provider system.
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
Mar 5, 2014
- Use LogWriterManager and LogProcessorManager services instead. - Added group annotations to tests
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
Mar 5, 2014
- trailing whitespace
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
Mar 5, 2014
| @@ -140,6 +141,20 @@ public function __construct($options = null) | |||
| throw new Exception\InvalidArgumentException('Options must be an array or an object implementing \Traversable '); | |||
| } | |||
|
|
|||
| // Inject writer plugin manager, if available | |||
| if (isset($options['writer_plugin_manager']) | |||
| && $options['writer_plugin_manager'] instanceof AbstractPluginManager | |||
There was a problem hiding this comment.
Why AbstractPluginManager and not just ServiceLocatorInterface?
There was a problem hiding this comment.
This is how we've typically written these, as it allows you to assume in your factories that you need to get the parent service locator instance if you need to get at app-level services.
|
This PR also requires a rebase |
- Allows passing the WriterPluginManager to the Logger constructor. - Adaptes the LoggerAbstractServiceFactory to inject the WriterPluginManager into the configuration prior to instantiating the logger.
- Allows passing the ProcessorPluginManager to the Logger constructor - Adaptes the LoggerAbstractServiceFactory to inject the ProcessorPluginManager into the configuration prior to instantiating the logger.
- LogWriterManager and LogProcessorManager services. - Wired into base service manager configuration, as well as ModuleManager feature provider system.
- Use LogWriterManager and LogProcessorManager services instead. - Added group annotations to tests
- trailing whitespace
weierophinney
added a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
…steners - LogWriterManager and LogProcessorManager services. - Wired into base service manager configuration, as well as ModuleManager feature provider system.
gianarb
pushed a commit
to zendframework/zend-modulemanager
that referenced
this pull request
May 15, 2015
…-writer-and-processor-config' into develop Close zendframework/zendframework#4455
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…to logger - Allows passing the WriterPluginManager to the Logger constructor. - Adaptes the LoggerAbstractServiceFactory to inject the WriterPluginManager into the configuration prior to instantiating the logger.
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…er to logger - Allows passing the ProcessorPluginManager to the Logger constructor - Adaptes the LoggerAbstractServiceFactory to inject the ProcessorPluginManager into the configuration prior to instantiating the logger.
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
… reflect MVC - Use LogWriterManager and LogProcessorManager services instead. - Added group annotations to tests
weierophinney
added a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
- trailing whitespace
gianarb
pushed a commit
to zendframework/zend-log
that referenced
this pull request
May 15, 2015
…-writer-and-processor-config' into develop Close zendframework/zendframework#4455
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want add to a logger my own writer who created by factory and I cann`t find any way for do this.
Here is the link to the stackoverflow, where I asked whether it is possible do that http://stackoverflow.com/questions/16414926/is-there-a-way-to-add-a-log-writer-factory-into-the-logger-configuration