Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Should we use constant for events in Zend\Db\TableGateway\Feature\EventFeature? #6569

Closed
dotuancd opened this issue Aug 13, 2014 · 3 comments · Fixed by #7066
Closed

Should we use constant for events in Zend\Db\TableGateway\Feature\EventFeature? #6569

dotuancd opened this issue Aug 13, 2014 · 3 comments · Fixed by #7066
Assignees
@Ocramius
Labels
Db enhancement
Milestone
2.3.4

Comments

@dotuancd
Copy link
Contributor

I think we should use constant for events in Zend\Db\TableGateway\Feature\EventFeature
@Ocramius
Copy link
Member

@dotuancd mind sending a PR? Constants over magic constants is of course much better/safer!

@samsonasik samsonasik mentioned this issue Aug 15, 2014
Closed
@samsonasik samsonasik mentioned this issue Oct 15, 2014
Closed
@samsonasik
Copy link
Contributor

@Ocramius I re-created PR #6766 with @dotuancd commit rebased against develop.

@samsonasik samsonasik mentioned this issue Dec 22, 2014
Merged
@Ocramius Ocramius added this to the 2.3.4 milestone Dec 22, 2014
@Ocramius Ocramius self-assigned this Dec 22, 2014
Ocramius added a commit that referenced this issue Dec 30, 2014
@Ocramius
#6569 #7066 - minor CS fixes (trailing whitespace, spacing)
43f7945
Ocramius added a commit that referenced this issue Dec 30, 2014
@Ocramius
Merge branch 'hotfix/#6569-#7066-use-constants-in-zend-db-tablegatewa…
b7e4a87 
…y-event-feature'

Close #6569
Close #7066
Ocramius added a commit that referenced this issue Dec 30, 2014
@Ocramius
Merge branch 'hotfix/#6569-#7066-use-constants-in-zend-db-tablegatewa…
1ad37c4 
…y-event-feature' into develop

Close #6569
Close #7066
Forward port #6569
Forward port #7066
@Ocramius
Copy link
Member

Handled in #7066

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
Db enhancement
Projects
None yet
Milestone
2.3.4
Development

Successfully merging a pull request may close this issue.

Use constant for events in Zend\Db\TableGateway\Feature\EventFeature samsonasik/zf2
3 participants
@Ocramius @samsonasik @dotuancd