This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Fix forms regression introduced in 2.2.3 #5028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This fixes a regression in 2.2.3 via zendframework#4996, whereby the fix to a regression caused a new regression in behavior, in which the form input filters were no longer being merged in the expected order. Essentially, the fix in zendframework#4996 now enforced the `preferFormInputFilter` flag status, which was de facto enabled due to the hacks previously present. This flag is now enabled by default to provide the behavior by default (which is what was occurring before the changes, albeit via a different mechanism).
|
👍 as far as review, but I can't merge right now, since I'm about to teach a class. @mwillbanks perhaps you can merge it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a "regression" discovered in #5007. Basically, fixes from #4996 made the
preferFormInputFilterflag actually have semantic meaning finally, and I discovered that the default value needed to be switched in order to retain the pre-2.2.3 form behavior.