This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[Zend-Code] Make sure that a use is only added once in ClassGenerator #4990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a unit test for this functionality (I can see regressions in the future without a test for this!) |
added 2 commits
August 21, 2013 09:09
This commit ensures that if someone adds a use twice it is only added once to the file.
|
Added unit test before fixing the bug. |
weierophinney
added a commit
that referenced
this pull request
Aug 21, 2013
[Zend-Code] Make sure that a use is only added once in ClassGenerator
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request ensures that if someone adds a use twice it is only added once to the file.