This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Correct spelling of function getMajorVersion #4830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the name of the function and provide a proxy for backwards compatibility. Refs #4804
|
I will review this pull request when I get home, I submitted this rough version from my phone at a family gathering. I will try to add tests and review the addition after I get home tonight. |
added 2 commits
July 14, 2013 20:02
Updated existing docblock to be more inline with other depricated functions and added the deprecation version
|
Nice, just change the calls to the old method (3 calls) in https://github.com/zendframework/zf2/blob/master/library/Zend/Cache/Storage/Adapter/Redis.php#L229 and go |
Update the Redis cache adapter to use the corrected function name getMajorVersion from the RedisResourceManager
|
Thanks for the help with my first contribution @Maks3w ! Hopefully everything is ready to go now. |
ghost
assigned
Maks3w
added a commit
that referenced
this pull request
Jul 15, 2013
Maks3w
added a commit
that referenced
this pull request
Jul 15, 2013
Maks3w
added a commit
that referenced
this pull request
Jul 15, 2013
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the name of the function and provide a proxy for backwards compatibility. Refs #4804