This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Split multiple implements into multiple lines #4640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| abstract class AbstractAdapter implements StorageInterface, EventsCapableInterface | ||
| abstract class AbstractAdapter implements | ||
| StorageInterface, | ||
| EventsCapableInterface |
There was a problem hiding this comment.
These are really only necessary when the line length gets to be too long (i.e. > 100-120 characters) -- in other words, only those files that have horizontal scrolls in the files listing of this PR.
There was a problem hiding this comment.
In #4362 (comment) you say
You should only ever split onto multiple lines, really, when there's more than one interface, or the line is getting too long. In the latter case, the interface name goes on the next line only; the word implements stays on the previous line.
ghost
assigned 
Closed
gianarb
pushed a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-server
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-server
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-ldap
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-ldap
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-session
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's close to calling it a day I'm issuing a no-brainer PR that does the following:
implementsof multiple interfaces into multiple lines (fixes PSR-2 and multiple implements #4362)usestatements for interfaces in the root namespaces (related to Root namespace for constants #4363)