Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

removed checks of not existing class Zend\Math\BigInteger #4633

Merged
merged 1 commit into from
Jun 12, 2013
Merged

removed checks of not existing class Zend\Math\BigInteger #4633

merged 1 commit into from
Jun 12, 2013

Conversation

marc-mabe
Copy link
Member

This addresses the last note of #3512
The second note seems to be fixed already

but the first one is already there and I cant fix:

#grep -iHrn 'ConstraintKeyObject' library/Zend/Db/
../library/Zend/Db/Metadata/Source/AbstractSource.php:398:                $keys[] = $key = new Object\ConstraintKeyObject($constraintKeyInfo['column_name']);

@ralphschindler @Maks3w ping

@@ -79,7 +79,6 @@ class Server extends AbstractServer
'i4' => 'i4',
'int' => 'int',
'integer' => 'int',
'Zend\Math\BigInteger' => 'i8',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove this?

BigInteger feature is not removed. Just the old deprecated message

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the class doesn't exist it's not possible to get this as PHP type

@ezimuel ezimuel merged commit 7ce2dba into zendframework:master Jun 12, 2013
@marc-mabe marc-mabe deleted the hotfix/3512 branch August 13, 2014 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants