Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Update StrategyInterface.php #4539

Closed
wants to merge 3 commits into from
Closed

Update StrategyInterface.php #4539

wants to merge 3 commits into from

Conversation

spiffyjr
Copy link
Contributor

@spiffyjr
Copy link
Contributor Author

You don't have to specify the optional object so this PR is not required (but for brevity may want to be merged).

@weierophinney
Copy link
Member

PHP considers optional arguments on an interface a part of the contract -- and thus any implementations need to define the optional argument as well, or else they will break the contract, and PHP will raise an error. As such, it is a BC break.

Just note the optional parameter as an annotation.

Kyle Spraggs added 2 commits May 24, 2013 11:37
@ghost ghost assigned weierophinney May 24, 2013
weierophinney added a commit that referenced this pull request May 24, 2013
Update StrategyInterface.php
weierophinney added a commit that referenced this pull request May 24, 2013
weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants