This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Allow Zend\Form\Element\Checkbox to return real value instead of always a boolean #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
that referenced
this pull request
May 23, 2013
Allow Zend\Form\Element\Checkbox to return real value instead of always a boolean
|
Thanks for this, @sjuvonen -- this was the intended behavior, but never tested and verified, obviously! |
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the way Zend's Checkbox element handles values. The Checkbox element allows us to set any value as checked/unchecked value via setCheckedValue() and setUncheckedValue(). The default value is (string) 1 for checked state.
The bug is that currently Checkbox will not follow these values based on its check state. Instead Checkbox::getValue() always returns a boolean true/false. After this patch Checkbox will return the value of getUncheckedValue() when isChecked() return false and value of getCheckedValue() when isChecked() returns true.
I also updated the ZendTest\Form\Element\CheckboxTest::testSetAttributeValue() to cover these other use-cases.