This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
sync svn r24702 - support application/x-zip in Validator\File\IsCompressed #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
uh, when I do google about "application/x-zip", "application/x-zip-compressed" is hit. |
ghost
assigned 
|
This is failing on, specifically, 5.3.3. Personally, I get issues for each of data sets 0, 1, 3, and 5. The same tests pass on 5.3.latest and 5.4.latest, however, which indicates to me an issue with ext/fileinfo. As such, we likely need some version-sniffing to make this work across versions. Are you able/willing to attempt this, @sasezaki ? |
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
May 6, 2013
sync svn r24702 - support application/x-zip in Validator\File\IsCompressed
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
May 6, 2013
- Was observing test failures due to calling markTestSkipped() inside a data provider. - Created new skipIfBuggyMimeContentType() method to call to skip a test if mime_content_type() returns buggy information for zip files
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
May 6, 2013
- Only skip if we're dealing with a zip type in the first place.
|
kinda strange. My environment ( Ubuntu + php 5.3.3 built with configure no option) pass IsCompressedTestphp. when using PHP 5.3.3 and other OS (or magic.mime) - composition, would not work?? |
weierophinney
added a commit
that referenced
this pull request
May 8, 2013
- Deprecated since 5.3.0, and fileinfo is enabled by default in vanilla PHP builds. It makes no sense to fallback to it, when finfo does a much better job.
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…idator_x_zip sync svn r24702 - support application/x-zip in Validator\File\IsCompressed
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
- Was observing test failures due to calling markTestSkipped() inside a data provider. - Created new skipIfBuggyMimeContentType() method to call to skip a test if mime_content_type() returns buggy information for zip files
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
- Only skip if we're dealing with a zip type in the first place.
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
- Deprecated since 5.3.0, and fileinfo is enabled by default in vanilla PHP builds. It makes no sense to fallback to it, when finfo does a much better job.
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sync of svn r24702.
for support application/x-zip
@see (commit-log)
https://bitbucket.org/sasezaki/mirror-zf1-standard-trunk-libraray-validate-dir/commits/deab989ef3728529ff4f0f35aba7ca6498643523
https://bitbucket.org/sasezaki/mirror-zf1-standard-trunk-tests-validate-dir/commits/c11495d2a6d3f191694820f9a9b6b7938a062fa8
original commit is using mime_content_type() function (yeah, it is deprecated) , so should be attention before merge this.