fix getHref strategy in PageMvc

[vnagara]

I was caused by problem which breaks menu link dependent from which page it was generated.

As example in one router I have default action 'list' in another - 'view'. Current getHref function replace proper default action parameter with broken from route match.
Also if I will add some new defaults then I should has to fix all entrances in navigation array.

[weierophinney]

A couple comments:

• For configuration values, we usually prefer "underscore_separated" names, as we can normalize them more easily. As such, I'd recommend naming the config value "use_route_match".
• You've altered existing test cases, which is generally a sign of a behavior change, and thus potentially a backwards compatibility break. I think we need to have distinct test cases for the behavior both with and without the flag. Ideally, the original test cases should be left intact.

[vnagara]

OK, I renamed it to underscore.
About second: It was introduced in v2.1.5 which caused troubles in navigation links and broke BC. I merely want to return this compatibility. So should I change others test functions?
@weierophinney thank for comment.

[weierophinney]

About second: It was introduced in v2.1.5 which caused troubles in navigation links and broke BC. I merely want to return this compatibility.

You hadn't mentioned that in the description. :)

If that's the case, then I'd argue the boolean true value of the flag should be the default behavior? If so, that's how it should be coded.

[vnagara]

@weierophinney Yeah, really, there should be applied more standards(I did fast fix for compatibility). Do you agree that default value of this param should be false?
At first I want do discuss what should be done than I could do it and in documentation too.
I've just mentioned why I'd used camel-case param, because such is used for 'routeMatch" param (http://zf2.readthedocs.org/en/latest/modules/zend.navigation.pages.html). Also doctrine use camel case params.

[vnagara]

ViewHelper has camel-case options - http://zf2.readthedocs.org/en/latest/modules/zend.navigation.view.helper.menu.html. So I propose to set 'useRouteMath' param to camel-cased too.

[weierophinney]

@vnagara Ugh -- thought we'd refactored all those before 2.0. Since we didn't, keep the casing consistent within the component.

As for the default value of the parameter -- the default should be whatever value will keep the original behavior prior to the changes in 2.1.5. The configuration value can then be passed when somebody wants to override the behavior.

[vnagara]

@weierophinney done

[weierophinney]

s/Rote/Route/g (I can do this on merge.)

[weierophinney]

Looks good -- I'll make the changes I've noted in suggestions already as I merge.

[vnagara]

@weierophinney Thank

[Slamdunk]

@weierophinney yes, this PR resolves #4095 bug.

But also restores the old behaviour, deleting #4095 intentions, in fact testMvcPageParamsInheritRouteMatchParams and testInheritedRouteMatchParamsWorkWithModuleRouteListener had to be changed.

I suggest to @adamlundrigan to play better with breadcrumbs view helper to reach his goal; now there's no more need to change Zend\Navigation\* anymore; a custom Zend\View\Helper\Navigation\* will be enough.

[weierophinney]

@Slamdunk The goal was to restore the pre-2.1.5 behavior, so it sounds like that has happened. It also allows the same behavior that @adamlundrigan was trying to achieve via a flag.

[Slamdunk]

Exactly what I mean and what It's needed 😄