Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some PNG images are not affected #9

Closed
kozis opened this issue Oct 31, 2014 · 5 comments
Closed

Some PNG images are not affected #9

kozis opened this issue Oct 31, 2014 · 5 comments

Comments

@kozis
Copy link

kozis commented Oct 31, 2014

Hello,
I found a problem with some PNG files. I have a many folders with PNG files and all of them are exported from photoshop by same method. But some of them are not affected by pngmin task. Do you know, where may be a problem? File "auto.png" (car) is ok, but "dum.png" (house) in same location is ignored. I tryied to rename it, crop and resave, but without success.
Thank You
Tom
dum
auto

@zauni
Copy link
Owner

zauni commented Nov 1, 2014

Hi,
I will have a look into it! Thanks for the report.

@zauni
Copy link
Owner

zauni commented Nov 2, 2014

I have tested now both pictures and both are getting minified... Can you post your gruntfile config for the pngmin task? Then I could try that config in my own machine. Thanks!

@kozis
Copy link
Author

kozis commented Nov 3, 2014

Hello, tanks for Your reply.
Here is a torso of project including Gruntfile.js:
https://app.box.com/s/lzd8avn41krn91p49hgu

@zauni
Copy link
Owner

zauni commented Nov 3, 2014

Hello kozis,
thanks for the files! Now I probably know whats causing problems. It's the "quality" option.
In the docs: "Instructs pngquant to use the least amount of colors required to meet or exceed the max quality. If conversion results in quality below the min quality the image won't be saved and pngquant will exit with status code 99".
So propably with one of your pictures, it's below the min quality and it's not saving it. As a quick workaround you shouldn't use the quality option.

I will make a bugfix this week and publish it to npm as soon as possible.

Thanks again for your report and I hope it's not a big problem to leave the quality option for the moment!

@kozis
Copy link
Author

kozis commented Nov 5, 2014

Hello Zauni,
thanks for quick response. Workaround with quality option is working for me.
Pngmin is a very useful plugin and I like having it in our workflow. :)

@zauni zauni closed this as completed in 6b21e9d Nov 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants