From 0e052ab5a89df3e561ff06f0e402f2761c38aa97 Mon Sep 17 00:00:00 2001
From: Anton-Ivanov <anton.i@hey.com>
Date: Wed, 17 Jul 2024 15:01:03 +0300
Subject: [PATCH] do not enqueue email job and do not create log when there is
 no any SMTP

---
 app/domain/contact_email_sender.rb       |  2 ++
 spec/domain/contact_email_sender_spec.rb | 15 ++++++++++++++-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/app/domain/contact_email_sender.rb b/app/domain/contact_email_sender.rb
index 119b79ce8..47f9bccd0 100644
--- a/app/domain/contact_email_sender.rb
+++ b/app/domain/contact_email_sender.rb
@@ -24,6 +24,8 @@ def initialize(contact)
   # @param message [String,nil]
   # @param attachments [Array<Notification::Attachment,nil]
   def send_email(subject:, message: nil, attachments: nil)
+    return if contact.smtp_connection.nil?
+
     ApplicationRecord.transaction do
       email_log = create_email_log(
         subject: subject,
diff --git a/spec/domain/contact_email_sender_spec.rb b/spec/domain/contact_email_sender_spec.rb
index 7fc616337..cd4ce5f68 100644
--- a/spec/domain/contact_email_sender_spec.rb
+++ b/spec/domain/contact_email_sender_spec.rb
@@ -23,7 +23,6 @@
         expect { subject }.to change { Log::EmailLog.count }.by(1)
         email_log = Log::EmailLog.last!
         expect(email_log).to have_attributes(expected_email_log_attrs)
-        expect(Worker::SendEmailLogJob).to have_been_enqueued.with(email_log.id)
       end
 
       it 'enqueues Worker::SendEmailLogJob' do
@@ -99,6 +98,19 @@
 
       include_examples :creates_email_log
     end
+
+    context 'when there is NO any SMTP connection' do
+      let(:global_smtp_connection) { nil }
+
+      it 'should NOT create Email Log' do
+        expect { subject }.not_to change(Log::EmailLog, :count)
+      end
+
+      it 'should NOT enqueue Job' do
+        subject
+        expect(Worker::SendEmailLogJob).not_to have_been_enqueued
+      end
+    end
   end
 
   describe '.batch_send_emails' do
@@ -106,6 +118,7 @@
       described_class.batch_send_emails(contacts, **service_params)
     end
 
+    let!(:global_smtp_conn) { FactoryBot.create(:smtp_connection, global: true) }
     let!(:contacts) do
       [
         FactoryBot.create(:contact, contractor: FactoryBot.create(:customer)),