From f09b74f0bbf817e3ab7c953e9d5f684d0e85c2a4 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Fri, 25 Feb 2022 18:53:58 -0800 Subject: [PATCH 1/3] chore(parsers): use const for vars data and sort --- packages/yarnpkg-parsers/sources/syml.ts | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/packages/yarnpkg-parsers/sources/syml.ts b/packages/yarnpkg-parsers/sources/syml.ts index 3b74cff20894..f737563ce8e9 100644 --- a/packages/yarnpkg-parsers/sources/syml.ts +++ b/packages/yarnpkg-parsers/sources/syml.ts @@ -55,16 +55,9 @@ function stringifyValue(value: any, indentLevel: number, newLineIfObject: boolea } if (typeof value === `object` && value) { - let data: any; - let sort: boolean; - - if (value instanceof PreserveOrdering) { - data = value.data; - sort = false; - } else { - data = value; - sort = true; - } + const [data, sort] = (value instanceof PreserveOrdering) + ? [value.data, false] + : [value, true]; const indent = ` `.repeat(indentLevel); From ce771bb4e424ba2c41186c38057120b801f1efa2 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Fri, 25 Feb 2022 18:54:35 -0800 Subject: [PATCH 2/3] chore: yarn version check --interactive --- .yarn/versions/768814ed.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 .yarn/versions/768814ed.yml diff --git a/.yarn/versions/768814ed.yml b/.yarn/versions/768814ed.yml new file mode 100644 index 000000000000..2191dab034eb --- /dev/null +++ b/.yarn/versions/768814ed.yml @@ -0,0 +1,11 @@ +releases: + "@yarnpkg/parsers": patch + +declined: + - "@yarnpkg/plugin-essentials" + - "@yarnpkg/plugin-nm" + - "@yarnpkg/plugin-version" + - "@yarnpkg/cli" + - "@yarnpkg/core" + - "@yarnpkg/sdks" + - "@yarnpkg/shell" From ea96f0702296ef2bb3c612978713a8b3dfb7c797 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Wed, 9 Mar 2022 08:00:19 -0800 Subject: [PATCH 3/3] Remove brackets from ternary operator condition --- packages/yarnpkg-parsers/sources/syml.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/yarnpkg-parsers/sources/syml.ts b/packages/yarnpkg-parsers/sources/syml.ts index f737563ce8e9..498df852d869 100644 --- a/packages/yarnpkg-parsers/sources/syml.ts +++ b/packages/yarnpkg-parsers/sources/syml.ts @@ -55,7 +55,7 @@ function stringifyValue(value: any, indentLevel: number, newLineIfObject: boolea } if (typeof value === `object` && value) { - const [data, sort] = (value instanceof PreserveOrdering) + const [data, sort] = value instanceof PreserveOrdering ? [value.data, false] : [value, true];