-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug?]: various yarn.lock modifications after v3 -> v4 migration #5957
Comments
Yes
See the changelog:
The different checksums aren't due to the mixed compression level (since it's the same as in 3.6, as we inlined the old default in your project), but just because we upgraded the libzip version. |
Ok, I was suspecting something like this, but couldn't find info about that. Thanks for the explanation.
The mystery of changed checksums is now resolved 😄 But what about the duplicated resolutions to dependencies? Is it some side-effect of the mixed compression level with a new lib, is it a new Yarn behaviour or is it a bug that "forgets" that some dependencies were already deduped? |
I just thought of running I'm 99% confident that it deduplicated all the resolutions that were added during the migration. After explicit deduping the lockfile now contains only additions of So it seems that migration from v3 to v4 reverted deduplication of packages I did a couple of days ago on my project. |
Hi! 👋 It seems like this issue as been marked as probably resolved, or missing important information blocking its progression. As a result, it'll be closed in a few days unless a maintainer explicitly vouches for it. |
Why is this closed? The other, related bug is still open... 🤷 |
Self-service
Describe the bug
After upgrading Tarn from 3.4.1 to 4.0.1, my 50k-line long
yarn.lock
had around 30k modified lines.I looked at the diff and saw the following:
some changed metadata (seems reasonable)
added
npm:
prefix to somedependencies
for some packages(ok, I guess?)(EDIT: implemented here: Normalizes dependencies #4305)new resolutions for existing dependencies (?!?)
I checked 3 times to make sure that these changes are not introduced by anything other than the sheer Yarn upgrade:
There are lots of other packages that got additional resolutions ("un-deduped")
Changed checksums for some packages (??)
This is what originally made me create this issue, but then I found there are other changes things as well.
And for some packages -- a mix of everything mentioned above:
Additionally, these are the changes in my
.yarnrc.yml
:So the main question is: are all these modifications expected during a migration?
Additional questions:
What was the default (implicit)
compressionLevel
before the upgrade (now it'smixed
)Does the
mixed
compression level make the checksum different (point 4.) ?To reproduce
N/A
Environment
yarn dlx -q envinfo --preset jest System: OS: macOS 14.0 CPU: (10) arm64 Apple M1 Pro Binaries: Node: 18.18.2 - /private/var/folders/9v/c77m1k_90wl3225q3pl3335w0000gq/T/xfs-45053198/node Yarn: 4.0.1 - /private/var/folders/9v/c77m1k_90wl3225q3pl3335w0000gq/T/xfs-45053198/yarn npm: 9.8.1 - /opt/homebrew/opt/nvm/versions/node/v18.18.2/bin/npm bun: 1.0.7 - ~/.bun/bin/bun
Additional context
No response
The text was updated successfully, but these errors were encountered: