Add FastBoot tests #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@simonihmig I merge #96 can you rebase? |
simonihmig
force-pushed
the
fastboot-tests
branch
from
7dc7422
to
a220240
Compare
|
@krisselden did that. Still a failing test, will investigate... |
|
thank you |
simonihmig
force-pushed
the
fastboot-tests
branch
from
a220240
to
2dcf23f
Compare
|
Stupid me, was just a copy paste error in tests... 🙄 Passing locally now, Travis will hopefully confirm... |
|
Travis is good to us! 🎉 |
|
🎉 Awesome! Thanks @simonihmig and @krisselden for getting this done! |
|
No Problem! @krisselden is this good to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FastBoot tests. One with
renderInPlacewhich is passing, and one normal one which is failing due to #86. #96 will hopefully fix the failing test...