Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong usage of global var versus function arg #38

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

lennde
Copy link
Contributor

@lennde lennde commented Jun 15, 2021

Currently in the connect_to_endpoint function, the variable 'search_url' in the GET request is used.
We should consider using the url parameter that is specified as an argument of the function.

@github-actions
Copy link

github-actions bot commented Jun 15, 2021

CLA Assistant Lite bot All Contributors have signed the CLA. If the commit check is not passing, a maintainer must go the Checks tab of this PR and rerun the GitHub Action.

@lennde
Copy link
Contributor Author

lennde commented Jun 15, 2021

I have read the CLA Document and I hereby sign the CLA

@lennde
Copy link
Contributor Author

lennde commented Jun 15, 2021

recheck

@lennde lennde closed this Jun 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2021
@lennde lennde reopened this Jun 15, 2021
@andypiper andypiper merged commit 2a7f4f8 into xdevplatform:master Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants