Blazor hang with marshal methods #7927

grendello · 2023-03-28T21:07:31Z

NOTE: LLVM IR generator updates are now done in #8140
Context: https://github.com/aspnet/AspNetCore-ManualTests/issues/1934

* main: [Xamarin.Android.Build.Tasks] Fix Android Version Code for Release builds (dotnet#7795)

Better string handling in LLVM IR generator

jonpryor · 2023-03-29T22:53:17Z

src/Xamarin.Android.Build.Tasks/Tasks/LinkApplicationSharedLibraries.cs

@@ -43,6 +46,10 @@ sealed class InputFiles
 		[Required]
 		public string AndroidBinUtilsDirectory { get; set; }

+		public string AndroidNdkDirectory { get; set; }


Does EnableMarshalMethodTracing require the NDK, and not just the clang build tools we already redistribute?

oh, it's to find libunwind.a!

Not only libunwind.a, also a few others from the compiler "private" collection (libc++abi.a, libclang_rt.builtins-<ARCH>-android.a)

Tracing no longer requires NDK to be present on the end user's machine

jonpryor · 2023-03-29T22:57:02Z

src/Xamarin.Android.Build.Tasks/Utilities/MarshalMethodsNativeAssemblyGenerator.cs

@@ -171,6 +171,9 @@ sealed class MarshalMethodName
 			{ 'L', typeof(_jobjectArray) },
 		};

+		const string mm_trace_func_enter_name = "_mm_trace_func_enter";


Seems kinda odd that most of the members here are camelCase or PascalCase, but then the new members are c_snake_case. Should this not be MMTraceFuncEnterName?

It's a standalone C/C++ function, so I used the C/C++ naming convention.

jonpryor · 2023-03-29T22:58:58Z

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

@@ -2085,6 +2087,8 @@ because xbuild doesn't support framework reference assemblies.
      ApplicationSharedLibraries="@(_ApplicationSharedLibrary)"
      DebugBuild="$(AndroidIncludeDebugSymbols)"
      AndroidBinUtilsDirectory="$(AndroidBinUtilsDirectory)"
+      EnableMarshalMethodTracing="$(_AndroidEnableMarshalMethodTracing)"


What happens when $(_AndroidEnableMarshalMethodTracing)=True and $(_AndroidNdkDirectory) isn't set and/or is the "internal" clang tooling? What's the error message look like? Is that error message acceptable?

(Sure, this is a private property for now, but even we make mistakes…)

For now it's ArgumentNullException(nameof (ndk)) in the method where we actually use the NDK. Not sure if we ever want to make this property "public", though.

No longer a problem, NDK not required anymore

jonpryor · 2023-03-29T23:01:04Z

src/monodroid/jni/marshal-methods-utilities.hh

+			return mm_class_names[class_index];
+		}
+
+		static uint64_t get_method_id (uint32_t mono_image_index, uint32_t method_token) noexcept


Out of curiosity, why "pack" these values into a uint64_t instead of a std::tuple<uint32_t, uint32_t> or some other struct?

It's a constant, faster to pass (no pointer, less memory access), can easily be used as a selector when looking for method name/description/etc in an array, and takes up less LLVM IR code (easier to read and understand, not to mention generate):

tail call void @_mm_trace_func_enter (i32 126, i32 0, i32 100664310, i8* getelementptr inbounds ([137 x i8], [137 x i8]* @__str.0, i64 0, i64 0)) #2 tail call void %get_func_ptr (i32 126, i32 0, i32 100664310, i8** nonnull align 8 dereferenceable(8) bitcast (void (%class._JNIEnv*, %class._jclass*, %class._jobject*, %class._jobject*, i32, i64)** @native_cb_onItemClick_126_0_60003f6 to i8**)) #2

if it were a pointer to a struct (or tuple) we'd need to output the struct declaration, variable definition, use a pointer which would be another ugly getelementptr invocation. It would make both calls, and especially the 2nd one, even uglier and less readable.

* main: [Mono.Android] Bind API-UpsideDownCake Developer Preview 1 (dotnet#7796) Bump to dotnet/installer@d109cba3ff 8.0.100-preview.4.23176.5 (dotnet#7921)

Use standalone libunwind instead of the LLVM's Instead of using autoconf on *nix and cmake on Windows, provide our own CMakeLists.txt file which works everywhere we need.

Building application with tracing currently fails because of __cxa_demangle missing symbols (it requires the built-in clang libunwind which we cannot use) - we will need our own demangler. Next week.

* main: [tests] Remove `net472` multitargeting (dotnet#7932) [monodroid] Fix `ld` build error on Nightly Builds. (dotnet#7925) Bump to xamarin/Java.Interop/main@0355acf (dotnet#7931) [tests] Use msftconnecttest.com in QuoteInvalidQuoteUrlsShouldWork (dotnet#7919) [ci] Don't set demands for megapipeline (dotnet#7929)

* provide library stubs for liblog and libdl * include libc++abi demangler directly in the trace library (its sources are part of the NDK) * better trace output The only remaining dependency on NDK is the clang builtins library (compiler-rt). Should be able to eliminate that too, with some tweaks.

At XA build time we find and package the compiler's builtins libraries for all the ABIs we support. This allows us to link libxamarin-app.so without requiring NDK to be present on end user's machine. Additionally, traces have now adjusted addresses and offsets for all frames, to match bionic behavior. Finally, the entire trace output is logged in a single message. This makes everything faster, but also makes sure that the trace won't be interleaved with unrelated messages in logcat.

* main: [readme] Add aka.ms links for d17.5. (dotnet#7935)

Also: introduce tracing modes, 'basic` for just the method enter/leave messages and 'full' to include native and java stack traces on method entry.

* main: [ci] Remove remaining Classic test jobs. (dotnet#7924) Add Nightly Tests for Humanizer

* main: [ci] Stop building classic test suites. (dotnet#7938)

It appears that the following might be cause of the "hang": 04-07 19:39:36.121 4859 4859 I chromium: [INFO:CONSOLE(2)] "Uncaught ReferenceError: Blazor is not defined", source: https://0.0.0.0/ (2) It is probably caused by this JavaScript fragment from Blazor: Blazor.start(); window.__BlazorStarted = true; And the Blazor class might not be initialized because of a problem with delegates using the "old" registration mechanism when marshal methods are enabled (there are quite a few of them in the test app). lldb didn't reveal anything interesting, process state appeared to be fine.

* main: [Xamarin.Android] Remove OpenTK, sqlite-xamarin, System.EnterpriseServices. (dotnet#7940)

* main: Bump to xamarin/Java.Interop/main@a172402 (dotnet#7944)

jonpryor · 2023-04-11T19:58:53Z

src/monodroid/jni/marshal-methods-tracing.cc

+	// TODO: error handling
+	trace.append ("\n  Java stack trace:");
+	jobject current_thread = env->CallStaticObjectMethod (java_lang_Thread, java_lang_Thread_currentThread);
+	auto stack_trace_array = static_cast<jobjectArray>(env->CallNonvirtualObjectMethod (current_thread, java_lang_Thread, java_lang_Thread_getStackTrace));


This should be CallObjectMethod, as java.lang.Thread.getStackTrace() is a virtual (non-final) method.

The same library will be used by marshal methods tracing (by linking it into `libxamarin-app.so` when tracing is enabled) or will be used by `libmonodroid.so` (or p/invoked from managed land) if desired.

* main: Bump com.android.tools:r8 from 4.0.52 to 8.0.40 (dotnet#7934)

* main: [Xamarin.Android.Build.Tasks] fix cases of missing `@(Reference)` (dotnet#7947) Bumping to the correct monodroid commit Trying to bump monodroid to run debugger-tests Pass timeout to runtime

Eventually to be used, optionally, by libmonodroid

* main: Convert `/tools` and `/build-tools` projects from `net472` to `$(DotNetStableTargetFramework)` (dotnet#7943)

The DSO is packaged only if marshal methods tracing is enabled or if native stack traces are enabled (via the `_UseNativeStackTraces` MSBuild property) Added a p/invoke which can log any combination of: native, java, managed stack traces as well as the state of signal handlers. Updated p/invoke dispatch tables

* main: Bump to xamarin/Java.Interop/main@554d819 (dotnet#7951) [Microsoft.Android.Sdk.ILLink] fix crash when TZ changes (dotnet#7956) [tests] Port 'Xamarin.Android.JcwGen-Tests.JcwGen-Tests' to .NET (dotnet#7949) [Xamarin.Android.Build.Tasks] remove `pdb2mdb` (dotnet#7950) [ci] Add some extra params to configure the test templates (dotnet#7955)

* main: [Xamarin.Android.Build.Tasks] <GenerateJavaStubs/> should open readonly in some cases (dotnet#8129) [Mono.Android] suppress/solve more illink warnings (dotnet#8063)

First two instructions implemented (`store` and `ret`), together with support for TBAA metadata (https://llvm.org/docs/LangRef.html#tbaa-metadata) `xamarin_app_init` now fully generated.

* main: Bump to Tessil/robin-map@784245b4 [v1.2.1] (dotnet#8128)

* main: [Xamarin.Android.Build.Tasks] Allow override of `uncompressedGlob` (dotnet#7965)

* main: Bump to dotnet/installer@8d98e5a6ba 8.0.100-preview.6.23318.1 (dotnet#8131)

Tomorrow, testing and cleanup

* main: [One .NET] fix 'dotnet publish' with no arguments (dotnet#8137) [build] consider `$NUGET_PACKAGES` for `$(XAPackagesDir)` (dotnet#8136) Bump external/xamarin-android-tools from `44885bc` to `3cee10b` (dotnet#8121)

* main: [tests] Remove `XASdkDeployTests` (dotnet#8139)

* main: Bump to google/bundletool@f17ce94a (dotnet#8135) [Xamarin.Android.Build.Tasks] Handle IOException in Aapt2Daemon (dotnet#8130) [tests] don't set `/uses-sdk@android:targetSdkVersion=34` by default (dotnet#8138)

* main: [Mono.Android] Bind and enumify API-34 (dotnet#8116)

* main: $(AndroidPackVersionSuffix)=preview.7; net8 is 34.0.0-preview.7 (dotnet#8149)

* main: [Xamarin.Android.Build.Tasks] MarshalMethodsAssemblyRewriter+new file (dotnet#8151) Bump to dotnet/installer@d2a244f560 8.0.100-preview.7.23325.5 (dotnet#8142)

* main: (306 commits) [templates] Remove redundant "template" from display name. (dotnet#8773) Bump to xamarin/Java.Interop/main@a7e09b7 (dotnet#8793) [build] Include MIT license in most NuGet packages (dotnet#8787) Bump to dotnet/installer@893b762b6e 9.0.100-preview.3.24153.2 (dotnet#8782) [docs] update notes about `dotnet-trace` and `dotnet-gcdump` (dotnet#8713) [Mono.Android] Fix race condition in AndroidMessageHandler (dotnet#8753) [ci] Fix SDL Sources Analysis for PRs from forks (dotnet#8785) [ci] Add 1ESPT override to MSBuild test stages (dotnet#8784) [ci] Do not use @self annotation for templates (dotnet#8783) [ci] Migrate to the 1ES template (dotnet#8747) [Mono.Android] fix trimming warnings, part 2 (dotnet#8758) [Xamarin.Android.Build.Tasks] set `%(DefineConstantsOnly)` for older API levels (dotnet#8777) [tests] fix duplicate sources in `NuGet.config` (dotnet#8772) Bump to xamarin/monodroid@e13723e701 (dotnet#8771) Bump to xamarin/xamarin-android-tools/main@37d79c9 (dotnet#8752) Bump to dotnet/installer@d070660282 9.0.100-preview.3.24126.2 (dotnet#8763) Bump to xamarin/java.interop/main@14a9470 (dotnet#8766) $(AndroidPackVersionSuffix)=preview.3; net9 is 34.99.0.preview.3 (dotnet#8765) [Mono.Android] Do not dispose request content stream in AndroidMessageHandler (dotnet#8764) Bump com.android.tools:r8 from 8.2.42 to 8.2.47 (dotnet#8761) ...

grendello · 2024-03-08T12:31:12Z

Migrated to #8800

grendello added 4 commits March 28, 2023 09:03

Some debug messages

31fa878

Merge branch 'main' into blazor-hang

40646c5

* main: [Xamarin.Android.Build.Tasks] Fix Android Version Code for Release builds (dotnet#7795)

Marshal methods tracing

a89f45b

Native backtrace implementation

fd06651

Better string handling in LLVM IR generator

jonpryor reviewed Mar 29, 2023

View reviewed changes

grendello added 14 commits March 30, 2023 09:09

Merge branch 'main' into blazor-hang

2193db1

* main: [Mono.Android] Bind API-UpsideDownCake Developer Preview 1 (dotnet#7796) Bump to dotnet/installer@d109cba3ff 8.0.100-preview.4.23176.5 (dotnet#7921)

[WIP] Stack unwinding (doesn't build yet)

0564634

Use standalone libunwind instead of the LLVM's Instead of using autoconf on *nix and cmake on Windows, provide our own CMakeLists.txt file which works everywhere we need.

Build and use our own libunwind

3732378

Building application with tracing currently fails because of __cxa_demangle missing symbols (it requires the built-in clang libunwind which we cannot use) - we will need our own demangler. Next week.

Merge branch 'main' into blazor-hang

1ca486a

* main: [readme] Add aka.ms links for d17.5. (dotnet#7935)

Java stack trace implemented

fb7f7e6

Also: introduce tracing modes, 'basic` for just the method enter/leave messages and 'full' to include native and java stack traces on method entry.

Merge branch 'main' into blazor-hang

2f58b13

* main: [ci] Remove remaining Classic test jobs. (dotnet#7924) Add Nightly Tests for Humanizer

Add signal handlers to the report

e3d2649

Merge branch 'main' into blazor-hang

581194e

* main: [ci] Stop building classic test suites. (dotnet#7938)

Merge branch 'main' into blazor-hang

a512324

* main: [Xamarin.Android] Remove OpenTK, sqlite-xamarin, System.EnterpriseServices. (dotnet#7940)

Merge branch 'main' into blazor-hang

8c1b27f

* main: Bump to xamarin/Java.Interop/main@a172402 (dotnet#7944)

jonpryor reviewed Apr 11, 2023

View reviewed changes

grendello added 7 commits April 11, 2023 23:22

Tracing code is going to live in a separate DSO

b8cb13d

The same library will be used by marshal methods tracing (by linking it into `libxamarin-app.so` when tracing is enabled) or will be used by `libmonodroid.so` (or p/invoked from managed land) if desired.

Merge branch 'main' into blazor-hang

0cf46bd

* main: Bump com.android.tools:r8 from 4.0.52 to 8.0.40 (dotnet#7934)

Merge branch 'main' into blazor-hang

61f2114

* main: [Xamarin.Android.Build.Tasks] fix cases of missing `@(Reference)` (dotnet#7947) Bumping to the correct monodroid commit Trying to bump monodroid to run debugger-tests Pass timeout to runtime

Put tracing code in a separate library

d0ef3e7

Eventually to be used, optionally, by libmonodroid

Merge branch 'main' into blazor-hang

469e752

* main: Convert `/tools` and `/build-tools` projects from `net472` to `$(DotNetStableTargetFramework)` (dotnet#7943)

grendello added 25 commits June 14, 2023 22:42

Beginnings of code generation

3d27e22

Merge branch 'main' into blazor-hang

fb63716

* main: [Xamarin.Android.Build.Tasks] <GenerateJavaStubs/> should open readonly in some cases (dotnet#8129) [Mono.Android] suppress/solve more illink warnings (dotnet#8063)

Code generation works

5e98bc3

First two instructions implemented (`store` and `ret`), together with support for TBAA metadata (https://llvm.org/docs/LangRef.html#tbaa-metadata) `xamarin_app_init` now fully generated.

Merge branch 'main' into blazor-hang

11bf0a7

* main: Bump to Tessil/robin-map@784245b4 [v1.2.1] (dotnet#8128)

Halfway through code generation

1ddf89f

Merge branch 'main' into blazor-hang

80c510a

* main: [Xamarin.Android.Build.Tasks] Allow override of `uncompressedGlob` (dotnet#7965)

call sorted out, tomorrow onto phi

5c17d76

Merge branch 'main' into blazor-hang

76e4d0c

* main: Bump to dotnet/installer@8d98e5a6ba 8.0.100-preview.6.23318.1 (dotnet#8131)

Conversion to the new LLVM IR complete for everything except tracing

33c9ac3

Tomorrow, testing and cleanup

Merge branch 'main' into blazor-hang

69bd75e

* main: [One .NET] fix 'dotnet publish' with no arguments (dotnet#8137) [build] consider `$NUGET_PACKAGES` for `$(XAPackagesDir)` (dotnet#8136) Bump external/xamarin-android-tools from `44885bc` to `3cee10b` (dotnet#8121)

Cleanup

4d8d4dc

A bit more cleanup

6799989

Merge branch 'main' into blazor-hang

60b0a13

* main: [tests] Remove `XASdkDeployTests` (dotnet#8139)

Update libunwind to 1.7.0

580aae9

Tracing progress

944b73b

Merge branch 'main' into blazor-hang

2c74196

* main: Bump to google/bundletool@f17ce94a (dotnet#8135) [Xamarin.Android.Build.Tasks] Handle IOException in Aapt2Daemon (dotnet#8130) [tests] don't set `/uses-sdk@android:targetSdkVersion=34` by default (dotnet#8138)

asprintf progress, new style

95d423d

Add some more tracing capabilities

1ef3255

Merge branch 'main' into blazor-hang

e148e1b

* main: [Mono.Android] Bind and enumify API-34 (dotnet#8116)

More tracing improvements

5316425

Merge branch 'main' into blazor-hang

c11f03b

* main: $(AndroidPackVersionSuffix)=preview.7; net8 is 34.0.0-preview.7 (dotnet#8149)

asprintf simpler, general call improvements, assorted fixes

b864253

Merge branch 'main' into blazor-hang

c1cad61

* main: [Xamarin.Android.Build.Tasks] MarshalMethodsAssemblyRewriter+new file (dotnet#8151) Bump to dotnet/installer@d2a244f560 8.0.100-preview.7.23325.5 (dotnet#8142)

Fixups after merge

76cd39a

grendello mentioned this pull request Mar 8, 2024

Blazor + marshal methods failure #8800

Draft

grendello closed this Mar 8, 2024

grendello deleted the blazor-hang branch March 8, 2024 12:31

github-actions bot locked and limited conversation to collaborators Apr 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blazor hang with marshal methods #7927

Blazor hang with marshal methods #7927

grendello commented Mar 28, 2023 •

edited

Loading

jonpryor Mar 29, 2023

jonpryor Mar 29, 2023

grendello Mar 30, 2023

grendello Apr 11, 2023

jonpryor Mar 29, 2023

grendello Mar 30, 2023

jonpryor Mar 29, 2023

grendello Mar 30, 2023

grendello Apr 11, 2023

jonpryor Mar 29, 2023

grendello Mar 30, 2023 •

edited

Loading

jonpryor Apr 11, 2023

grendello commented Mar 8, 2024

Blazor hang with marshal methods #7927

Blazor hang with marshal methods #7927

Conversation

grendello commented Mar 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grendello Mar 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grendello commented Mar 8, 2024

grendello commented Mar 28, 2023 •

edited

Loading

grendello Mar 30, 2023 •

edited

Loading