Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support declare transactions with version 0x0 #420

Closed
fracek opened this issue Jun 30, 2023 · 2 comments · Fixed by #423
Closed

Support declare transactions with version 0x0 #420

fracek opened this issue Jun 30, 2023 · 2 comments · Fixed by #423

Comments

@fracek
Copy link
Contributor

fracek commented Jun 30, 2023

I'm testing starknet-rs on the integration network and it looks like DeclareTransaction is missing the old V0 transactions. They still exist, for example in this block.

According to the pathfinder team, these transactions have the same representation as V1 transactions but with the version set to 0x0. I can see that the openapi spec is confusing with naming, but technically the version field can be 0x0 even in DECLARE_TXN_V1.
@xJonathanLEI
Copy link
Owner

Hmm I didn't know that. Do such transactions exist in any live network though? If it's only on integration there would be little point supporting it.

@fracek
Copy link
Contributor Author

fracek commented Jul 1, 2023

Yes, for example block 13 on testnet 2. https://alpha4-2.starknet.io/feeder_gateway/get_block?blockNumber=13

@xJonathanLEI xJonathanLEI mentioned this issue Jul 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support DECLARE tx v0 xJonathanLEI/starknet-rs
2 participants
@fracek @xJonathanLEI