Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove third-party dependency on react-native-hsv-color-picker #5847

Closed
Tracked by #53359
derekblank opened this issue Jun 9, 2023 · 4 comments
Closed
Tracked by #53359

Remove third-party dependency on react-native-hsv-color-picker #5847

derekblank opened this issue Jun 9, 2023 · 4 comments
Assignees
Labels
dependencies Pull requests that update a dependency file [Pri] Low

Comments

@derekblank
Copy link
Contributor

derekblank commented Jun 9, 2023

Is your feature request related to a problem? Please describe.
The react-native-hsv-color-picker library is an unmaintained forked third-party dependency that uses no native resources, and is only used in one Gutenberg file (the native color picker). The library is small enough that it could be implemented directly within our code as part of the native color picker (or as a native color picker utility).

Removing the third-party dependency would simplify future React Native upgrades.

Describe the solution you'd like

  1. Take the source of react-native-hsv-color-picker and incorporate it as part of the native Gutenberg color picker files.
  2. Convert the code from a class to a function component in the process, and modify any library code that would better suit the project.
  3. Remove the third-party react-native-hsv-color-picker package dependency and delete the repo.

Describe alternatives you've considered
Continue to use the forked third-party library as-is, or use the original react-native-hsv-color-picker library as a non-forked dependency.

@derekblank derekblank added dependencies Pull requests that update a dependency file [Pri] Low labels Jun 9, 2023
@derekblank derekblank self-assigned this Jun 9, 2023
@fluiddot
Copy link
Contributor

fluiddot commented Jun 9, 2023

Thanks for opening the ticket @derekblank 🙇 ! I also considered this when reviewing the dependencies for the React Native upgrade. It shouldn't be too complex to implement a picker similar to what we have in https://github.com/lukewalczak/react-native-hsv-color-picker/blob/master/src/HsvColorPicker.js.

@derekblank
Copy link
Contributor Author

Just a heads up -- I've started working on this issue during downtime in between other tasks.

@derekblank
Copy link
Contributor Author

Resolved in WordPress/gutenberg#53329.

@fluiddot
Copy link
Contributor

Now that we no longer use the forked repository https://github.com/wordpress-mobile/react-native-hsv-color-picker, I'm going to archive it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file [Pri] Low
Projects
None yet
Development

No branches or pull requests

2 participants