Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

[CYS Woo Express] Search bar #11408

Closed
Tracked by #11086
verofasulo opened this issue Oct 23, 2023 · 6 comments · Fixed by #11445
Closed
Tracked by #11086

[CYS Woo Express] Search bar #11408

verofasulo opened this issue Oct 23, 2023 · 6 comments · Fixed by #11445
Assignees
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@verofasulo
Copy link

There are issues with the search bar when the background is not white.

image image

Also, please align the style of the search bar in the header and in the footer—we currently have 2 different styles.

@nefeline
Copy link
Contributor

@verofasulo can you please clarify a few things here?

There are issues with the search bar when the background is not white.

Can you please confirm the expected outcome here? Should the background color within the search bar match the one selected in the pattern assembler?

Also, please align the style of the search bar in the header and in the footer—we currently have 2 different styles.

Which one of the styles do you want to preserve: the one we have for the header or the footer? It would be great if you could provide us with an updated design so we can have a reference.

@nefeline nefeline added the type: enhancement The issue is a request for an enhancement. label Oct 23, 2023
@verofasulo
Copy link
Author

Hey @nefeline!

Which one of the styles do you want to preserve: the one we have for the header or the footer?

In the designs, there's no inconsistency—this is the search bar's style adopted everywhere:

image

The following are all the headers and footers implemented in the assembler and they all share the same search bar:

Can you please confirm the expected outcome here? Should the background color within the search bar match the one selected in the pattern assembler?

In Jarek's design, I can see there's no fill—So I would expect not to have the white background 😊

@gigitux
Copy link
Contributor

gigitux commented Oct 24, 2023

Hey, @verofasulo

In Jarek's design, I can see there's no fill—So I would expect not to have the white background 😊

It is not possible to change the background of the input field: WordPress/gutenberg#44671

Also, please align the style of the search bar in the header and in the footer—we currently have 2 different styles.

Could you expand this? The only difference that I see is the label:

image

@verofasulo
Copy link
Author

It is not possible to change the background of the input field: WordPress/gutenberg#44671

Thanks, Luigi. Let's go with the white background, then.

Could you expand this? The only difference that I see is the label:

image
  • Some headers have this style, with no space between the input field and the search button.
  • The border-radius is different. Sometimes it's 0px, sometimes 2px (it looks like this). It's not something inherited by the theme.
  • And yes, the label—could we use Search everywhere, please?

@gigitux gigitux linked a pull request Oct 25, 2023 that will close this issue
13 tasks
@verofasulo
Copy link
Author

Addressing this comment here that came out from the last QA — The current search bar presents border-radius inconsistencies between the input field and the search button:

image

Please use 0px for both of the elements.

@albarin
Copy link
Contributor

albarin commented Oct 31, 2023

@verofasulo fixed here: #11514

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants