Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in RNPDFPdfViewManagerInterface interface causing android build crash #745

Merged

Conversation

MuhmdRaouf
Copy link
Contributor

fix typo which causing android build to crash with the following error message

> Task :react-native-pdf:compileReleaseJavaWithJavac FAILED
/Users/runner/work/1/s/node_modules/react-native-pdf/android/src/main/java/org/wonday/pdf/PdfManager.java:29: error: PdfManager is not abstract and does not override abstract method showsVerticalScrollIndicator(PdfView,boolean) in RNPDFPdfViewManagerInterface
public class PdfManager extends SimpleViewManager<PdfView> implements RNPDFPdfViewManagerInterface<PdfView> {
       ^
/Users/runner/work/1/s/node_modules/react-native-pdf/android/src/main/java/org/wonday/pdf/PdfManager.java:97: error: method does not override or implement a method from a supertype
    @Override
    ^
/Users/runner/work/1/s/node_modules/react-native-pdf/android/src/main/java/org/wonday/pdf/PdfManager.java:102: error: method does not override or implement a method from a supertype
    @Override
    ^
Note: /Users/runner/work/1/s/node_modules/react-native-pdf/android/src/main/java/org/wonday/pdf/PdfView.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
3 errors

@wonday wonday merged commit 1e69117 into wonday:master Jun 25, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants