Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astro check not working in astro.build repo #8246

Closed
1 task
FredKSchott opened this issue Aug 27, 2023 · 3 comments
Closed
1 task

astro check not working in astro.build repo #8246

FredKSchott opened this issue Aug 27, 2023 · 3 comments
Labels
needs triage Issue needs to be triaged

Comments

@FredKSchott
Copy link
Member

FredKSchott commented Aug 27, 2023

Astro info

Astro version            v3.0.0-rc.7
Package manager          pnpm
Platform                 darwin
Architecture             arm64
Adapter                  @astrojs/vercel/serverless
Integrations             @astrojs/tailwind, @astrojs/solid-js, @astrojs/mdx, @astrojs/sitemap, @astrojs/prefetch

What browser are you using?

Chrome

Describe the Bug

Issue 1

  1. In the https://github.com/withastro/astro.build repo
  2. Run pnpm astro check
  3. See the following output:
Screen Shot 2023-08-27 at 9 59 26 AM

Issue 2

  1. Install @astrojs/check manually
  2. Run pnpm astro check
  3. See the same output as above, even though @astrojs/check is installed:
Screen Shot 2023-08-27 at 10 03 54 AM

What's the expected result?

I didn't have @astrojs/check installed, so I expected to see that first message. However, it re-asked me to install typescript in that second prompt and then failed.

This may be a pnpm issue, and not a Astro 3.0 issue. I'll test this on Astro 2.0 now to confirm.

Link to Minimal Reproducible Example

https://github.com/withastro/astro.build

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Aug 27, 2023
@FredKSchott
Copy link
Member Author

FredKSchott commented Aug 27, 2023

Update: this seems to be an issue in Astro 2.x as well, I just reproduced this Astro 2.0.

I also tried reproducing this in a smaller repo (using both Astro 2 and the new Astro 3 flow) and could not reproduce, so it may be something specific to the astro.build codebase that is causing it.

Screen Shot 2023-08-27 at 10 18 37 AM

@FredKSchott FredKSchott changed the title astro check not working in RC astro check not working in astro.build repo Aug 27, 2023
@Princesseuh
Copy link
Member

Princesseuh commented Aug 27, 2023

The second issue is fixed already, but the fix isn't released yet #8237. Not quite sure about the rest, this command doesn't load the Astro config, so I don't think it's specific to astro check 🤔

@Princesseuh
Copy link
Member

#8237 fixed this and checking out the astro.build repo myself, everything works. Please open another issue if you encounter anything new, but I think the errors in your screenshot might just be RC versions being weird or your setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants