ForbiddenCallTimePassByReference: fix false positive for "bitwise and" preceded by global constant #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" preceded by global constant This was a known false positive and annotated as such in the unit test files. Simplified the `isCallTimePassByReferenceParam()` method by using the upstream `isReference()` function to determine whether a _bitwise and_ is a reference or not. The upstream method has some issues pre PHPCS 3.1.1, but none which impact this sniff. Fixes 39
wimg
approved these changes
Dec 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a known false positive and annotated as such in the unit test files.
Simplified the
isCallTimePassByReferenceParam()method by using the upstreamisReference()function to determine whether a bitwise and is a reference or not.The upstream method has some issues pre PHPCS 3.1.1, but none which impact this sniff.
Fixes #39