Readme: Improve grammar of the reporting information #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wimg
reviewed
Dec 24, 2017
README.md
Outdated
| @@ -138,6 +134,8 @@ Sniffing your code for compatibility with specific PHP version(s) | |||
| - You can run the checks for just one specific PHP version by adding `--runtime-set testVersion 5.5` to your command line command. | |||
| - You can also specify a range of PHP versions that your code needs to support. In this situation, compatibility issues that affect any of the PHP versions in that range will be reported: `--runtime-set testVersion 5.3-5.5`. | |||
| - As of PHPCompatibility 7.1.3, you can omit one part of the range if you want to support everything above or below a particular version, i.e. use `--runtime-set testVersion 7.0-` to run all the checks for PHP 7.0 and above. | |||
| * By default the report will be send to the console, if you want to save the report to a file, add the following to the command line command: `--report-full=path/to/report-file`. | |||
There was a problem hiding this comment.
Fixed up the existing commit.
The same message was now shown twice, with one still containing a typo. This PR moves the message out of the installation instructions, to the readme section on running PHPCompatibility. It also improves the grammer of the text.
jrfnl
force-pushed
the
feature/fix-grammer
branch
from
1775c4a
to
36c0ceb
Compare
wimg
approved these changes
Dec 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same message was now shown twice, with one still containing a typo.
This PR moves the message out of the installation instructions, to the readme section on running PHPCompatibility.
It also improves the grammer of the text.