NewFunctions: Add new OCI functions

[jrfnl]

Refs:

• http://php.net/manual/en/migration72.new-functions.php#migration72.new-functions.oci8
• http://php.net/manual/en/function.oci-register-taf-callback.php
• http://php.net/manual/en/function.oci-unregister-taf-callback.php
• php/php-src@1b797f7
• php/php-src@de65a22

[wimg]

Waaaah... didn't see this one before I created my own version. The big question is : should we target 7.0 or 7.1 ?

[jrfnl]

The big question is : should we target 7.0 or 7.1 ?

I was thinking about that last night as well. The reason I've chosen the 7.1.x versions is that the function is 100% fine if 7.1.7/9 or higher is the "targetVersion" (testVersion) for PHPCompatibility.
With 7.0.xx, 7.1.0 would pass without issue, but in reality does not support the function yet.

[jrfnl]

There are some more cases like this here and there. We may want to take a principle decision (always use lowest/highest PHP version where the function first appeared/was deprecated in last) and verify that the logic is applied consistently throughout the PHPCompatibility sniffs.

[Edit]: Oh and add it to the contributors guidelines so it's documented.

[jrfnl]

I've created a new issue for the "consistency when something is added/removed in multiple versions" question.

[jrfnl]

And now I know why I didn't pull this before: php/php-src@9379b31#diff-7748eb3bfdd3bf962553f6f9f2723c45