Build/PHPCS: check array indentation #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPCS upstream has added a new sniff to verify normalized array indentation. As the PHPCS build check for the PHPCompatibility standard is run against `master`, we can start taken advantage of that. This commit adds the relevant changes to the PHPCompatibility own ruleset to do so and fixes the one instance where the code did not yet comply with this.
wimg
approved these changes
Dec 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPCS upstream has added a new sniff to verify normalized array indentation.
As the PHPCS build check for the PHPCompatibility standard is run against
master, we can start taking advantage of that.This commit adds the relevant changes to the PHPCompatibility own ruleset to do so and fixes the one instance where the code did not yet comply with this.