PHP 7.2: New OptionalRequiredFunctionParameters sniff #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a `RequiredOptionalFunctionParameters` sniff has been added which checks for missing function call parameters which were required and only became optional in a later PHP version. This PR adds a sister-sniff which checks for missing function call parameters which originally were optional, but later became required. Initially this sniff check for the `$results` parameter for the `parse_str()` function for which the optional nature of the parameter became deprecated in PHP 7.2 (soft required). It is expected that the parameter will become hard required in PHP 8.0. Includes unit tests. Notes: The commit contains a few minor changes to the `RequiredOptionalFunctionParameters` sniff to bring both sniffs in line with each other.
wimg
approved these changes
Nov 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a
RequiredOptionalFunctionParameterssniff has been added which checks for missing function call parameters which were required and only became optional in a later PHP version.This PR adds a sister-sniff which checks for missing function call parameters which originally were optional, but later became required.
Initially this sniff checks for the
$resultsparameter for theparse_str()function for which the optional nature of the parameter became deprecated in PHP 7.2 (soft required).It is expected that the parameter will become hard required in PHP 8.0.
Refs:
Includes unit tests.
Notes:
The commit contains a few minor changes to the
RequiredOptionalFunctionParameterssniff to bring both sniffs in line with each other.