Sync FindExtendedClassname() method with upstream
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/sync-in-upstream-change-extends
branch
from
80e9aac
to
a304da3
Compare
Synced in the changes as were just merged from squizlabs/PHP_CodeSniffer/pull/ 1473 This allows the method to also detect the "Extended Classname" for interfaces extending other interfaces. Adjusted the related `getFQExtendedClassName()` method accordingly and added unit tests for this change. The change to the `FindExtendedClassname()` method is tested upstream.
jrfnl
force-pushed
the
feature/sync-in-upstream-change-extends
branch
from
a304da3
to
2be6838
Compare
wimg
approved these changes
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synced in the changes as were just merged from squizlabs/PHP_CodeSniffer/pull/1473
This allows the method to also detect the "Extended Classname" for interfaces extending other interfaces.
Adjusted the related
getFQExtendedClassName()method accordingly and added unit tests for this change.The change to the
FindExtendedClassname()method is tested upstream.